Implementation for complex sorting of dndarrays by Berkant03 · Pull Request #2482 · helmholtz-analytics/heat

Berkant03 · 2026-08-24T13:48:46Z

Due Diligence

General:
- title of the PR is suitable to appear in the Release Notes
Implementation:
- unit tests: all split configurations tested
- unit tests: multiple dtypes tested
- NEW unit tests: MPS tested (1 MPI process, 1 GPU)
- benchmarks: created for new functionality
- benchmarks: performance improved or maintained
- documentation updated where needed

Description

Use vectorized_sort to implement a complex sort similar to np.sort_complex.

Issue/s resolved: #2372

Changes proposed:

Create a ht.sort_complex similar to np.sort_complex.
Reuse row exchange fuctionality of vectorized_sort.

Type of change

New feature (non-breaking change which adds functionality)

Does this change modify the behaviour of other functions? If so, which?

vectorized_sort, extraction of the communication logic into a seperate function.

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

brownbaerchen · 2026-08-25T10:38:28Z

I marked the PR as draft because I couldn't find any actual implementation or tests for the new feature.

codecov · 2026-08-25T14:44:48Z

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

- Started with `sort_complex`

for more information, see https://pre-commit.ci

…es/2372-complex_sort

…torized_sort

…_sort

for more information, see https://pre-commit.ci

- Added final `sort_complex` - integrated `sort_complex` into `sort` - added tests for `sort` for complex arrays

for more information, see https://pre-commit.ci

- add split axis for non distributed case.

for more information, see https://pre-commit.ci

brownbaerchen

I pointed out a few places where outdated code needs to be removed, mostly as a note to myself...

…_sort

for more information, see https://pre-commit.ci

… features/2372-complex_sort

brownbaerchen

resplit_result in sort_complex not implemented

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

brownbaerchen

A few more small things... Sorry about that :D

brownbaerchen · 2026-09-08T15:09:26Z

        assert np.isclose(res.numpy(), expected_res).all()
        assert a.device == res.device
        assert np.equal(sort_idx, res_idxs.numpy()).all()
        assert a.device == res_idxs.device


Can we add tests that the split is what we expect? Since we are touching this above, and since we were missing something with the devices last time, I think this would be useful.

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

for more information, see https://pre-commit.ci

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

- added assertion for global index

…_sort

for more information, see https://pre-commit.ci

… features/2372-complex_sort

for more information, see https://pre-commit.ci

github-project-automation Bot added this to Roadmap Aug 24, 2026

github-project-automation Bot moved this to Todo in Roadmap Aug 24, 2026

Berkant03 changed the title ~~Implemenation for complex sorting of dndarrays~~ Implementation for complex sorting of dndarrays Aug 24, 2026

brownbaerchen marked this pull request as draft August 25, 2026 10:37

brownbaerchen force-pushed the features/2372-complex_sort branch from daf9b19 to 5bc0d77 Compare August 25, 2026 13:44

brownbaerchen force-pushed the features/2372-complex_sort branch from 0f36767 to 7d610a4 Compare August 26, 2026 08:24

Base automatically changed from 363-vectorized-sorting to main August 26, 2026 14:11

Berkant03 and others added 3 commits August 26, 2026 16:11

- Extracted the exchange logic of vectorized_sort

fb0ba46

- Started with `sort_complex`

[pre-commit.ci] auto fixes from pre-commit.com hooks

1f85501

for more information, see https://pre-commit.ci

Fixed missing import

a886580

brownbaerchen force-pushed the features/2372-complex_sort branch from 7d610a4 to a886580 Compare August 26, 2026 14:11

brownbaerchen and others added 15 commits August 31, 2026 16:32

Add failing test

8e9342e

Fix test

b5c8633

Specify device in a few places

cadff06

Fix test for real this time

26580db

Complex sort implementation.

fc25e35

Merge remote-tracking branch 'origin/vectorized_sort_gpu' into featur…

29815be

…es/2372-complex_sort

add device specification

d500a9e

add original_split parameter to have correct reorder behaviour in vec…

33dade2

…torized_sort

Merge remote-tracking branch 'origin/main' into features/2372-complex…

d16e3ad

…_sort

[pre-commit.ci] auto fixes from pre-commit.com hooks

1e59936

for more information, see https://pre-commit.ci

- Removed stable parameter

fdb6104

- Added final `sort_complex` - integrated `sort_complex` into `sort` - added tests for `sort` for complex arrays

- Added test for reorder

52aeea6

[pre-commit.ci] auto fixes from pre-commit.com hooks

92ef942

for more information, see https://pre-commit.ci

- changed complex array generation

7fd4218

- better numpy version handling

c4a3e51

- add split axis for non distributed case.

pre-commit-ci Bot and others added 3 commits September 8, 2026 08:29

[pre-commit.ci] auto fixes from pre-commit.com hooks

b50ce27

for more information, see https://pre-commit.ci

changed split axis for the non distributed case

a85066b

Change the split of the index array

60d03c1

brownbaerchen reviewed Sep 8, 2026

View reviewed changes

Comment thread heat/core/manipulations.py Outdated

Allow local reordering when not on axis != split

4305e94

brownbaerchen requested changes Sep 8, 2026

View reviewed changes

Comment thread heat/core/manipulations.py Outdated

Comment thread heat/core/manipulations.py Outdated

Comment thread heat/core/manipulations.py Outdated

Comment thread heat/core/manipulations.py Outdated

Comment thread heat/core/manipulations.py Outdated

Berkant Palazoglu and others added 5 commits September 8, 2026 13:31

Merge remote-tracking branch 'origin/main' into features/2372-complex…

6dc072d

…_sort

remove the resplit from reorder

71aa8c4

[pre-commit.ci] auto fixes from pre-commit.com hooks

6398226

for more information, see https://pre-commit.ci

Fix nameerrors due to api change

0d7c66d

Merge remote-tracking branch 'origin/features/2372-complex_sort' into…

605d147

… features/2372-complex_sort

brownbaerchen requested changes Sep 8, 2026

View reviewed changes

Comment thread heat/core/manipulations.py

Comment thread heat/core/manipulations.py Outdated

Berkant03 and others added 2 commits September 8, 2026 15:34

Update heat/core/manipulations.py

c5177b8

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

Update heat/core/manipulations.py

3e2123e

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

brownbaerchen requested changes Sep 8, 2026

View reviewed changes

Berkant03 and others added 15 commits September 8, 2026 17:36

Update heat/core/manipulations.py

e16d7d8

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

Update heat/core/manipulations.py

91fe22e

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

a4fcf10

for more information, see https://pre-commit.ci

Update heat/core/manipulations.py

4af0aad

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

Update tests/core/test_sorting.py

219c3ba

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

Update heat/core/manipulations.py

4104d9e

Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>

- changed pos of the clone

1ff8355

- added assertion for global index

renaming or reorder to take

fbee41b

Merge remote-tracking branch 'origin/main' into features/2372-complex…

b64f446

…_sort

update documentation.

2a80883

[pre-commit.ci] auto fixes from pre-commit.com hooks

65e2942

for more information, see https://pre-commit.ci

removed assertion, to allow np.take like behaviour

9132d4e

Merge remote-tracking branch 'origin/features/2372-complex_sort' into…

9f9075f

… features/2372-complex_sort

allow None Axis and similar behaviour to np.take

7ec9262

[pre-commit.ci] auto fixes from pre-commit.com hooks

c488015

for more information, see https://pre-commit.ci

Uh oh!

Conversation

Berkant03 commented Aug 24, 2026

Due Diligence

Description

Changes proposed:

Type of change

Does this change modify the behaviour of other functions? If so, which?

Uh oh!

brownbaerchen commented Aug 25, 2026

Uh oh!

codecov Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ JUnit XML file not found

Uh oh!

Uh oh!

brownbaerchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brownbaerchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brownbaerchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brownbaerchen Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Aug 25, 2026 •

edited

Loading